Can someone clue me in to why this does the opposite of what I want? Spark goes back to normal in pwr enrich instead of retarding.

CB6A: LDAB L006A ; Load MPH
CB6C: CMPB LC02A ; Compare to Max Speed for Retard
CB6F: BHI LCB7E ; Branch if Higher
CB71: BRCLR L0044,$#20,LCB7E ; Branch if b5 Not Set
CB75: LDD L011E ; Load Total Spark Val
CB78: SUBB LC029 ; Subtract Launch Retard
CB7B: STD L011E ; Save to Total Spak Val

 

Ok, I could be completely wrong here, but it looks like this is your problem.

CB75: LDD L011E ; Load Total Spark Val This loads the double accumulator with
the total spark value.

CB78: SUBB LC029 ; Subtract Launch Retard This subtracts the launch retard from
accumulator B.

CB7B: STD L011E ; Save to Total Spak Val And this stores the double accumulator
back to total spark value.

I think you need to do this

CB78: SUBD LC029 ; Subtract Launch Retard

Just a guess on my part, but I would say that the B accumulator is not part of the Double accumulator, and you need to double check this as I don't have the pink book.

 

The launch spark retard is intended to only be active when the car is taking off from a stop. Similar logic has been used in other PCMs and ECMs. The intent being to reduce the SA during low RPM, high load conditions. This is not intended to continously provide retard, but transient retard during hard low speed load transitions. The MPH theshold ensures that it will only be active for a period of time. Im not familiar with the V6 code, but there are probably TPS and other qualifications as well.

Perhapse Im not fully understanding the question, but if you want retard in PE, use the PE spark retard table.

 

BTW, is this code that you wrote? Or is this from a stock mask as the title implies?

Jim is right that the SUBB will not produce a carry if the SA is a 16 bit value stored in the AB accumulator. Also keep in mind that the SUBD statement will need, I think, one more byte of program and calibration address space if you wrote the code as a patch.

 

This is what I wrote. It was a compromise based on the space I have. I should probably add something to round off the A accumulator but no space. It actually does what I want, but not when I want. It retards out of PE and goes back to normal in PE. I've changed the command to branch if set but it still does the same thing?!?!